dynamically allocate model in ResultsTree

[firewave]

No description provided.

[firewave]

QTreeView::setModel() takes a pointer, so given the usual Qt pattern this will surely take ownership of the object. So when ResultTree is being destroyed the model would be destroyed by the owner and RAII - if the previous assumption is correct.

Unfortunately this does not fix other crashing issues related to the results.

[firewave]

Okay, now that test leaks memory. So it seems the tree won't take the ownership.

[firewave]

Something is wrong with a QVariant object. If you call clearData() before the problematic setData() calls you get a segmentation fault with a local object.

[firewave]

I pushed the minimized reproducer so it can be reproduced easily.

[firewave]

It will only fail with GCC so since the ASAN job uses Clang it will always pass.

[firewave]

It looks like the data passed to setData() is being accessed by reference and going out of scope destroys it. Nothing it noted about this in the documentation. Making that variable static makes it work. But then it should be showing issues with either compiler.

[firewave]

I forgot to pass --track-origins=yes option to valgrind. Now I get this:

==26739== Use of uninitialised value of size 8
==26739==    at 0x5B4F527: QtPrivate::QMetaTypeForType<QMap<QString, QVariant> >::getDtor()::{lambda(QtPrivate::QMetaTypeInterface const*, void*)#1}::_FUN(QtPrivate::QMetaTypeInterface const*, void*) (in /usr/lib/libQt6Core.so.6.9.1)
==26739==    by 0x5B8E595: QVariant::operator=(QVariant const&) (in /usr/lib/libQt6Core.so.6.9.1)
==26739==    by 0x55D67B4: QStandardItem::setData(QVariant const&, int) (in /usr/lib/libQt6Gui.so.6.9.1)
==26739==    by 0x4007422: TestResultsTree::test1() const (testresultstree.cpp:30)
==26739==    by 0x40046FF: TestResultsTree::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_testresultstree.cpp:72)
==26739==    by 0x5B2E19A: QMetaMethodInvoker::invokeImpl(QMetaMethod, void*, Qt::ConnectionType, long long, void const* const*, char const* const*, QtPrivate::QMetaTypeInterface const* const*) (in /usr/lib/libQt6Core.so.6.9.1)
==26739==    by 0x5B2EA3E: QMetaMethod::invokeImpl(QMetaMethod, void*, Qt::ConnectionType, long long, void const* const*, char const* const*, QtPrivate::QMetaTypeInterface const* const*) (in /usr/lib/libQt6Core.so.6.9.1)
==26739==    by 0x50187AE: ??? (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x501BA81: ??? (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x502916F: QTest::qRun() (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x502A0B5: QTest::qExec(QObject*, int, char**) (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x4007636: main (testresultstree.cpp:37)
==26739==  Uninitialised value was created by a heap allocation
==26739==    at 0x4861F93: operator new(unsigned long) (vg_replace_malloc.c:487)
==26739==    by 0x400A9F8: QMap<QString, QVariant>::detach() (qmap.h:279)
==26739==    by 0x4009DDF: QMap<QString, QVariant>::operator[](QString const&) (qmap.h:379)
==26739==    by 0x400730C: TestResultsTree::test1() const (testresultstree.cpp:27)
==26739==    by 0x40046FF: TestResultsTree::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_testresultstree.cpp:72)
==26739==    by 0x5B2E19A: QMetaMethodInvoker::invokeImpl(QMetaMethod, void*, Qt::ConnectionType, long long, void const* const*, char const* const*, QtPrivate::QMetaTypeInterface const* const*) (in /usr/lib/libQt6Core.so.6.9.1)
==26739==    by 0x5B2EA3E: QMetaMethod::invokeImpl(QMetaMethod, void*, Qt::ConnectionType, long long, void const* const*, char const* const*, QtPrivate::QMetaTypeInterface const* const*) (in /usr/lib/libQt6Core.so.6.9.1)
==26739==    by 0x50187AE: ??? (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x501BA81: ??? (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x502916F: QTest::qRun() (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x502A0B5: QTest::qExec(QObject*, int, char**) (in /usr/lib/libQt6Test.so.6.9.1)
==26739==    by 0x4007636: main (testresultstree.cpp:37)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[firewave]

If you call setModel() you get the pointer of the previously model and are supposed to delete that. So dynamically allocate it to be in line with that. Unfortunately this does not fix anything and the minimal reproducer for the actual issue is in the related ticket.

[danmar]

Unfortunately this does not fix anything and the minimal reproducer for the actual issue is in the related ticket.

Can you please clarify if this PR fix the issue and you want it merged?

[firewave]

Can you please clarify if this PR fix the issue and you want it merged?

It does not fix the issue (I removed the reference from the title) - and I want it merged as it correctly implements the usage of a model.

[danmar]

it feels like somebody else will someday try to change this back to avoid that new is used..