removed usage of default parameters from Token::insertToken*()#7813
Merged
chrchr-github merged 1 commit intodanmar:mainfrom Sep 11, 2025
Merged
removed usage of default parameters from Token::insertToken*()#7813chrchr-github merged 1 commit intodanmar:mainfrom
Token::insertToken*()#7813chrchr-github merged 1 commit intodanmar:mainfrom
Conversation
Collaborator
Author
|
Mostly prevents the performance regression caused by #7296. |
Collaborator
Author
|
Callgrind from CI: |
this avoids the unnecessary creation of `std::string` objects
firewave
force-pushed
the
insert-tok-xxy
branch
from
15faf28 to
698cf1f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this avoids the unnecessary creation of
std::stringobjects