#14173: Add Valuetype type and sign for stdint macros

[swasti16]

No description provided.

[firewave]

There should be a ticket related to this - but it possible we forgot to file one when those macros were dropped in #5527 - after they were moved in #5421.

[firewave]

Still needs a ticket and we should also file a follow-up about {U}INTMAX_C() (see https://en.cppreference.com/w/c/types/integer.html).

[danmar]

you need to compare the platform sizes. An int can be 16 bits.

[firewave]

We should probably put the logic into platform.cpp so it can be re-used.

I also found the "ticket" - it's the extensive list in a TODO in Platform::getLimitsDefines().

[firewave]

The actual ticket: https://trac.cppcheck.net/ticket/11928#comment:4.

[firewave]

We could also just generate defines which would simplify the code. Here's the compiler output for reference (the macros will be mapped to the non-reserved ones in the headers):

$ clang++ -dM -E - < /dev/null | grep _C\(
#define __INT16_C(c) c
#define __INT32_C(c) c
#define __INT64_C(c) c##L
#define __INT8_C(c) c
#define __INTMAX_C(c) c##L
#define __UINT16_C(c) c
#define __UINT32_C(c) c##U
#define __UINT64_C(c) c##UL
#define __UINT8_C(c) c
#define __UINTMAX_C(c) c##UL

[danmar]

We should probably put the logic into platform.cpp so it can be re-used.

hmm if we put it in platform.cpp then that file must include symboldatabase.h :-(

how about putting it in ValueType instead the symboldatabase already has a Settings dependency anyway.

[danmar]

We could also just generate defines which would simplify the code. Here's the compiler output for reference (the macros will be mapped to the non-reserved ones in the headers):

I don't want to reuse those macros they will make it impossible to implement the Misra C rules. The code INT8_C(1000) would be preprocessed into 1000..

[danmar]

yes a ticket is needed. 👍

@firewave for your information I asked swasti to implement this and my motivation is that we need it for misra c. it would have been nice to replace UINT32_C(1) with 1U or (uint32_least_t)1 or something like that but that solution makes it hard to implement some Misra C checkers for proper usage of these macros unfortunately.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud