Skip to content

Make it easier to control symbol exports#7877

Merged
danmar merged 1 commit intodanmar:mainfrom
sodero:topic/dont_hardcade_rdynamic
Oct 12, 2025
Merged

Make it easier to control symbol exports#7877
danmar merged 1 commit intodanmar:mainfrom
sodero:topic/dont_hardcade_rdynamic

Conversation

@sodero
Copy link
Copy Markdown
Contributor

@sodero sodero commented Oct 11, 2025

By not hardcoding RDYNAMIC it's possible to control exporting from the commandline on platforms/compilers that don't support -rdynamic.

@firewave firewave self-assigned this Oct 11, 2025
@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Oct 11, 2025

Thanks for your contribution.

It was already possible to override it but you need to specify it after the make command.

Comment thread Makefile Outdated
@firewave
Copy link
Copy Markdown
Collaborator

Stupid me. The Makefile is obviously generated by dmake and all changes need to be done in dmake.cpp.

@sodero
Copy link
Copy Markdown
Contributor Author

sodero commented Oct 11, 2025

Stupid me. The Makefile is obviously generated by dmake and all changes need to be done in dmake.cpp.

Aha! I didn't even notice that there was such a thing. Interesting solution. I updated dmake.cpp as well.

By not hardcoding RDYNAMIC it's possible to control exporting
from the commandline on platforms/compilers that don't support
-rdynamic.
@sodero sodero force-pushed the topic/dont_hardcade_rdynamic branch from d54a476 to 39571e2 Compare October 11, 2025 19:46
@sonarqubecloud
Copy link
Copy Markdown

@firewave
Copy link
Copy Markdown
Collaborator

Aha! I didn't even notice that there was such a thing. Interesting solution. I updated dmake.cpp as well.

If we would use more generic rules and dependency files we could probably reduce it a lot. But since it works and it wouldn't really improve things that is not worth the time spent - especially given how much else there is to do.

@danmar
Copy link
Copy Markdown
Owner

danmar commented Oct 12, 2025

@firewave I assume you are OK that I merge this..

@danmar danmar merged commit 97dfca9 into danmar:main Oct 12, 2025
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants