fixed some -Wnrvo Clang compiler warnings#7883
Open
firewave wants to merge 2 commits intodanmar:mainfrom
Open
Conversation
|
danmar
reviewed
Oct 25, 2025
| checkRecursive(expr, startEndTokens.first, startEndTokens.second->next(), exprVarIds, local, true, depth); | ||
| if (result.type != Result::Type::NONE) | ||
| return result; | ||
| { |
Owner
There was a problem hiding this comment.
this is quite pedantic by clang imho. FwdAnalysis::Result is small and simple data. But yes if we want to turn on the warning then you have to fix all warnings so I guess there's not much we can do.
| return "0.0"; | ||
| if (s.find_first_of(".e") == std::string::npos) | ||
| return s + ".0"; | ||
| s = "0.0"; |
Owner
There was a problem hiding this comment.
hmm I like the old code better here from a readability point of view.
| result = execute(elseStart->scope()); | ||
| } else { | ||
| return {unknown()}; | ||
| result = {unknown()}; |
Owner
There was a problem hiding this comment.
it is less obvious what happens here. if the loop continues then other results can be returned.. so I want to see an unconditional return.
| overflow = true; | ||
| indexValues.push_back(values.front()); | ||
| } | ||
| if (overflow) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.