Fix #2062 FN variable scope can be reduced (class instance)

[chrchr-github]

No description provided.

[firewave]

Did you just move the code or did you also make some adjustments?

[chrchr-github]

Did you just move the code or did you also make some adjustments?

Just moved it.

[firewave]

And https://trac.cppcheck.net/ticket/14194 is not yet fixed by this? (If not I would be fine with a different PR addressing it).

[chrchr-github]

And https://trac.cppcheck.net/ticket/14194 is not yet fixed by this? (If not I would be fine with a different PR addressing it).

That one probably needs to be handled at the library level, or with some hard-coding for templates like std::pair.

[firewave]

That one probably needs to be handled at the library level, or with some hard-coding for templates like std::pair.

Since those are detected as "used" there should also be logic in that check which can be leveraged by the scope check.

[chrchr-github]

Since those are detected as "used" there should also be logic in that check which can be leveraged by the scope check.

std.cfg has <check>std::pair</check> , which leads to an unusedVariable FP for e.g. std::pair<T, U> p; (unknown types which might have side effects).

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[firewave]

std.cfg has <check>std::pair</check> , which leads to an unusedVariable FP for e.g. std::pair<T, U> p; (unknown types which might have side effects).

Ah - I did not test that. I did test it with user structs though.

[chrchr-github]

std.cfg has <check>std::pair</check> , which leads to an unusedVariable FP for e.g. std::pair<T, U> p; (unknown types which might have side effects).

Ah - I did not test that. I did test it with user structs though.

See https://trac.cppcheck.net/ticket/14201