Skip to content

Fixed #14129 (false positive: unusedPrivateFunction with __attribute__((unused))) #7916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 2 commits into from
Oct 28, 2025
Merged

Fixed #14129 (false positive: unusedPrivateFunction with __attribute__((unused))) #7916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26752b
Fixed #14129 (false positive: unusedPrivateFunction with __attribute_…
danmar Oct 27, 2025
2b1df39
out of line definition
danmar Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,11 +1342,11 @@ void CheckClass::privateFunctions()

while (!privateFuncs.empty()) {
const auto& pf = privateFuncs.front();
if (pf->token->isAttributeMaybeUnused()) {
if (pf->token->isAttributeMaybeUnused() || pf->token->isAttributeUnused()) {
privateFuncs.pop_front();
continue;
}
if (pf->tokenDef && pf->tokenDef->isAttributeMaybeUnused()) {
if (pf->tokenDef && (pf->tokenDef->isAttributeMaybeUnused() || pf->tokenDef->isAttributeUnused())) {
privateFuncs.pop_front();
continue;
}
Expand Down
14 changes: 14 additions & 0 deletions test/testunusedprivfunc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ class TestUnusedPrivateFunction : public TestFixture {

TEST_CASE(templateSimplification); //ticket #6183
TEST_CASE(maybeUnused);
TEST_CASE(attributeUnused); // #14129
TEST_CASE(trailingReturn);
}

Expand Down Expand Up @@ -890,6 +891,19 @@ class TestUnusedPrivateFunction : public TestFixture {
ASSERT_EQUALS("", errout_str());
}

void attributeUnused() {
check("class C {\n"
" __attribute__((unused)) int f() { return 42; }\n"
"};");
ASSERT_EQUALS("", errout_str());

check("class C {\n"
" __attribute__((unused)) int f();\n"
"};\n"
"int C::f() { return 42; }\n");
ASSERT_EQUALS("", errout_str());
}

void trailingReturn() {
check("struct B { virtual void f(); };\n"
"struct D : B {\n"
Expand Down