Skip to content

Tokenizer: added missing end token in __typeof matching in setVarIDPass1()#7952

Merged
firewave merged 1 commit intodanmar:mainfrom
firewave:decl-tok
Nov 10, 2025
Merged

Tokenizer: added missing end token in __typeof matching in setVarIDPass1()#7952
firewave merged 1 commit intodanmar:mainfrom
firewave:decl-tok

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Nov 10, 2025

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Nov 10, 2025

Observed in common/file.c from https://github.com/neutrinolabs/xrdp,

Clang 19 - 1,309,274,453 -> 1,087,882,577

CC @ludviggunne

@firewave firewave requested a review from ludviggunne November 10, 2025 00:31
@firewave firewave changed the title Tokenizer: add missing end token in __typeof matching in `setVarIDPass1() Tokenizer: add missing end token in __typeof matching in setVarIDPass1() Nov 10, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firewave firewave changed the title Tokenizer: add missing end token in __typeof matching in setVarIDPass1() Tokenizer: added missing end token in __typeof matching in setVarIDPass1() Nov 10, 2025
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Nov 10, 2025

The code in question was introduced in a4faec0.

@firewave firewave merged commit 2af570d into danmar:main Nov 10, 2025
55 checks passed
@firewave firewave deleted the decl-tok branch November 10, 2025 15:15
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Nov 10, 2025

On a side note.

__typeof is only matched <= C23 - shouldn't that be matched for C unconditionally?

And MSVC also has __typeof__ - see https://learn.microsoft.com/en-us/cpp/c-language/typeof-c.

@ludviggunne
Copy link
Copy Markdown
Collaborator

ludviggunne commented Nov 17, 2025

Hm, I'll take a look at that. It was a while ago that I wrote that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludviggunne ludviggunne ludviggunne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @ludviggunne