Skip to content

Fix #4491 FN redundantAssignment: assigning same value twice #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Nov 11, 2025
Merged

Fix #4491 FN redundantAssignment: assigning same value twice #7955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d003c
Update testother.cpp
chrchr-github Nov 10, 2025
5ee0115
Update checkother.cpp
chrchr-github Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ void CheckOther::checkRedundantAssignment()
// Is there a redundant assignment?
const Token *start;
if (tok->isAssignmentOp())
start = tok->next();
start = tok->astOperand2();
else
start = tok->findExpressionStartEndTokens().second->next();

Expand Down
9 changes: 9 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11032,6 +11032,15 @@ class TestOther : public TestFixture {
" a = x;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("int f(int a, int b, int c) {\n" // #4491
" int x = a + b;\n"
" if (c)\n"
" x = a + b;\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2:11] -> [test.cpp:4:9]: (style) Variable 'x' is assigned an expression that holds the same value. [redundantAssignment]\n",
errout_str());
}

void varFuncNullUB() { // #4482
Expand Down