Fixed #14266 (documentation: clarify how -i works)#7961
Merged
danmar merged 7 commits intodanmar:mainfrom Nov 14, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR clarifies the documentation for the -i command-line option to better explain when and how it filters files. The key clarification is that -i only filters translation units based on their source filename before preprocessing begins, and does not apply to headers included during preprocessing.
Key Changes:
- Updated the manual section title from "Excluding a file or folder from checking" to "Exclude files matching a given pattern"
- Clarified that filtering happens on source filenames before preprocessing, not during preprocessing or analysis
- Added explicit notes directing users to use
--suppressfor filtering warnings in headers - Updated command-line help text to use more precise terminology ("translation units", "source filename")
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| man/manual.md | Updated section heading and expanded explanation of -i option behavior, emphasizing that filtering happens before preprocessing and only applies to source files |
| cli/cmdlineparser.cpp | Revised help text for -i option to clarify it skips translation units based on source filename and recommends suppressions for header warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
olabetskyi
previously approved these changes
Nov 13, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
olabetskyi
previously approved these changes
Nov 14, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.