You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a bit hacky. I think it would be good to rework the compile_commands.json import a bit. Right now we parse the whole command string or create a command string from arguments by just joining the arguments. I think we should do it the other way around, i.e. split the command string like the shell would, and handle that list/arguments as an argv list, like the compiler would.
This is a bit hacky. I think it would be good to rework the compile_commands.json import a bit. Right now we parse the whole command string or create a command string from arguments by just joining the arguments. I think we should do it the other way around, i.e. split the command string like the shell would, and handle that list/arguments as an argv list, like the compiler would.
+1
yes I also considered this. Should we try to tweak the code it's a bit cludgy.. or should we refactor it..
maybe the current approach was fine in the beginning but now we have reached the point where we see that it will simplify the code to break it up..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit hacky. I think it would be good to rework the compile_commands.json import a bit. Right now we parse the whole
commandstring or create a command string fromargumentsby just joining the arguments. I think we should do it the other way around, i.e. split thecommandstring like the shell would, and handle that list/argumentsas anargvlist, like the compiler would.