Skip to content

Fix 14306. Import project: include path in quotes is not read#8017

Merged
ludviggunne merged 5 commits intodanmar:mainfrom
ludviggunne:14306
Dec 7, 2025
Merged

Fix 14306. Import project: include path in quotes is not read#8017
ludviggunne merged 5 commits intodanmar:mainfrom
ludviggunne:14306

Conversation

@ludviggunne
Copy link
Copy Markdown
Collaborator

@ludviggunne ludviggunne commented Dec 6, 2025

This is a bit hacky. I think it would be good to rework the compile_commands.json import a bit. Right now we parse the whole command string or create a command string from arguments by just joining the arguments. I think we should do it the other way around, i.e. split the command string like the shell would, and handle that list/arguments as an argv list, like the compiler would.

@danmar
Copy link
Copy Markdown
Owner

danmar commented Dec 6, 2025

This is a bit hacky. I think it would be good to rework the compile_commands.json import a bit. Right now we parse the whole command string or create a command string from arguments by just joining the arguments. I think we should do it the other way around, i.e. split the command string like the shell would, and handle that list/arguments as an argv list, like the compiler would.

+1

yes I also considered this. Should we try to tweak the code it's a bit cludgy.. or should we refactor it..
maybe the current approach was fine in the beginning but now we have reached the point where we see that it will simplify the code to break it up..

Comment thread .github/workflows/selfcheck.yml
Comment thread lib/importproject.cpp
Comment thread lib/importproject.cpp
Comment thread lib/importproject.cpp Outdated
Comment thread lib/importproject.cpp Outdated
Comment thread lib/importproject.cpp Fixed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 7, 2025

Copy link
Copy Markdown
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ludviggunne ludviggunne merged commit d6f30e4 into danmar:main Dec 7, 2025
55 checks passed
@ludviggunne ludviggunne deleted the 14306 branch December 7, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants