Skip to content

DAOS-18881 object: increment counters on csum errors#18158

Open
janekmi wants to merge 1 commit intomasterfrom
janekmi/DAOS-18881-increment-counters-on-csum-err
Open

DAOS-18881 object: increment counters on csum errors#18158
janekmi wants to merge 1 commit intomasterfrom
janekmi/DAOS-18881-increment-counters-on-csum-err

Conversation

@janekmi
Copy link
Copy Markdown
Contributor

@janekmi janekmi commented May 1, 2026

Restored after #17828

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@janekmi janekmi requested a review from NiuYawei May 1, 2026 13:40
@janekmi janekmi requested review from a team as code owners May 1, 2026 13:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Ticket title is 'checksum/csum_error_logging.py:CsumErrorLog.test_csum_error_logging - failed due to Checksum Error Log not incremented'
Status is 'In Progress'
Labels: 'ci_master_daily,scrubbed_2.8,triaged'
https://daosio.atlassian.net/browse/DAOS-18881

Restored after #17828

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi force-pushed the janekmi/DAOS-18881-increment-counters-on-csum-err branch from ff3c4a0 to 47bfe10 Compare May 1, 2026 13:54
@janekmi janekmi marked this pull request as draft May 6, 2026 10:48
@janekmi janekmi marked this pull request as ready for review May 6, 2026 14:12
Comment thread src/object/srv_obj.c
return;
}

bio_log_data_csum_err(bxc);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should regard all csum errors as media error.

What about introducing a parameter to this function? Like
obj_log_csum_err(daos_unit_oid_t oid, bool media_err)
{
Raise general csum error event;
if (media_err) {
Raise media csum error event;
}

This function is called in three places, one is from client csum error reporting, the other two have network transfer involved, so they are not media error, however, there is a fault injection of DAOS_CSUM_CORRUPT_DISK for simulating media error, so the "obj_log_csum_error(oid, true)" should only be called for this fault injection case. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants