DAOS-18881 object: increment counters on csum errors#18158
DAOS-18881 object: increment counters on csum errors#18158
Conversation
|
Ticket title is 'checksum/csum_error_logging.py:CsumErrorLog.test_csum_error_logging - failed due to Checksum Error Log not incremented' |
Restored after #17828 Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
ff3c4a0 to
47bfe10
Compare
| return; | ||
| } | ||
|
|
||
| bio_log_data_csum_err(bxc); |
There was a problem hiding this comment.
I don't think we should regard all csum errors as media error.
What about introducing a parameter to this function? Like
obj_log_csum_err(daos_unit_oid_t oid, bool media_err)
{
Raise general csum error event;
if (media_err) {
Raise media csum error event;
}
This function is called in three places, one is from client csum error reporting, the other two have network transfer involved, so they are not media error, however, there is a fault injection of DAOS_CSUM_CORRUPT_DISK for simulating media error, so the "obj_log_csum_error(oid, true)" should only be called for this fault injection case. What do you think?
Restored after #17828
Steps for the author:
After all prior steps are complete: