Skip to content

DAOS-18890 dfuse: Enhance error handling in close_dup_fd and finalize_myhook functions #18159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mchaarawi wants to merge 2 commits into
base: master
Choose a base branch
from
+411 −132
Open

DAOS-18890 dfuse: Enhance error handling in close_dup_fd and finalize_myhook functions #18159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6da2813
DAOS-18890 dfuse: Enhance error handling in close_dup_fd and finalize…
mchaarawi May 1, 2026
ff8e6d9
DAOS-18890 pil4dfs: defer file_obj cleanup until active users release it
mchaarawi May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/client/dfuse/pil4dfs/aio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/**
* (C) Copyright 2024 Intel Corporation.
* (C) Copyright 2026 Hewlett Packard Enterprise Development LP
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
*/
Expand Down Expand Up @@ -257,13 +258,18 @@ io_submit(io_context_t ctx, long nr, struct iocb *ios[])
req_args->sgl.sg_iovs = &req_args->iov;

if (op == IO_CMD_PREAD) {
struct file_obj *file_obj = get_live_file_obj_idx(fd, "io_submit:PREAD");

if (file_obj == NULL)
D_GOTO(err_loop, rc = errno);
rc = daos_event_register_comp_cb(&ctx_ev->ev, aio_req_cb, req_args);
if (rc) {
DL_ERROR(rc, "daos_event_register_comp_cb() failed");
D_GOTO(err_loop, rc);
}
rc = dfs_read(d_file_list[fd]->dfs_mt->dfs, d_file_list[fd]->file,
&req_args->sgl, ios[i]->u.c.offset, &read_size, &ctx_ev->ev);
rc = dfs_read(file_obj->dfs_mt->dfs, file_obj->file, &req_args->sgl,
ios[i]->u.c.offset, &read_size, &ctx_ev->ev);
put_live_file_obj(file_obj);
if (rc) {
rc2 = daos_event_fini(&ctx_ev->ev);
if (rc2)
Expand All @@ -272,13 +278,18 @@ io_submit(io_context_t ctx, long nr, struct iocb *ios[])
}
}
if (op == IO_CMD_PWRITE) {
struct file_obj *file_obj = get_live_file_obj_idx(fd, "io_submit:PWRITE");

if (file_obj == NULL)
D_GOTO(err_loop, rc = errno);
rc = daos_event_register_comp_cb(&ctx_ev->ev, aio_req_cb, req_args);
if (rc) {
DL_ERROR(rc, "daos_event_register_comp_cb() failed");
D_GOTO(err_loop, rc);
}
rc = dfs_write(d_file_list[fd]->dfs_mt->dfs, d_file_list[fd]->file,
&req_args->sgl, ios[i]->u.c.offset, &ctx_ev->ev);
rc = dfs_write(file_obj->dfs_mt->dfs, file_obj->file, &req_args->sgl,
ios[i]->u.c.offset, &ctx_ev->ev);
put_live_file_obj(file_obj);
if (rc) {
rc2 = daos_event_fini(&ctx_ev->ev);
if (rc2)
Expand Down
Loading
Loading