SRE-3764 build: downgrade leap to 15.5 for 2.6#18166
SRE-3764 build: downgrade leap to 15.5 for 2.6#18166grom72 wants to merge 1 commit intorelease/2.6from
Conversation
Leap version (minor) is defined by the pipeline lib, no need to provide full information in stage's name. See daos-stack/pipeline-lib#512 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Skip-build-el8-gcc: true Skip-build-el9-gcc: true Skip-unit-tests:true Skip-unit-test: true Skip-NLT: true Skip-unit-test-memcheck: true Skip-func-test-el8: true Skip-func-test-el9: true Skip-func-test-leap15: false Skip-fault-injection-test: true Skip-test-el-9.6-rpms: true Skip-test-el-9-rpms: true Skip-func-hw-test: true
|
Errors are Unable to load ticket data |
phender
left a comment
There was a problem hiding this comment.
I still don't believe we want to use the daos-stack/pipeline-lib#512 change due to the potential impact to all branches.
Instead, couldn't we keep the stage name change here, but pass ' --build-arg POINT_RELEASE=.5 ' as an additionalBuildArgs to dockerfile().
In addition, we would need the ability to pass a "15.5" to buildRpm() to override the current parseSatgeInfo['distro_version'], but that's fairly easy with something like:
Map stage_info = parseStageInfo(config)
String target = config.get('target', stage_info['target'])
String distro_version = config.get('distro_version', stage_info['distro_version'])
...
String env_vars = ''
env_vars = ' TARGET=' + target +
' DISTRO_VERSION=' + distro_version
phender
left a comment
There was a problem hiding this comment.
I recant my previous objection.
Please ignore. The pipeline-lib change only affects release/2.6. |
| // To use a test branch (i.e. PR) until it lands to master | ||
| // I.e. for testing library changes | ||
| //@Library(value='pipeline-lib@your_branch') _ | ||
| @Library(value='pipeline-lib@grom72/SRE-3764') _ |
There was a problem hiding this comment.
We will need to remove this first before landing
Leap version (minor) is defined by the pipeline lib, no need to provide full information in stage's name.
See daos-stack/pipeline-lib#512
Signed-off-by: Tomasz Gromadzki tomasz.gromadzki@hpe.com
Steps for the author:
After all prior steps are complete: