Skip to content

SRE-3764 build: downgrade leap to 15.5 for 2.6#18166

Open
grom72 wants to merge 1 commit intorelease/2.6from
grom72/SRE-3764-2.6-2nd
Open

SRE-3764 build: downgrade leap to 15.5 for 2.6#18166
grom72 wants to merge 1 commit intorelease/2.6from
grom72/SRE-3764-2.6-2nd

Conversation

@grom72
Copy link
Copy Markdown
Contributor

@grom72 grom72 commented May 4, 2026

Leap version (minor) is defined by the pipeline lib, no need to provide full information in stage's name.
See daos-stack/pipeline-lib#512

Signed-off-by: Tomasz Gromadzki tomasz.gromadzki@hpe.com

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Leap version (minor) is defined by the pipeline lib, no need to provide
full information in stage's name.
See daos-stack/pipeline-lib#512

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Priority: 2

Skip-build-el8-gcc: true
Skip-build-el9-gcc: true

Skip-unit-tests:true
Skip-unit-test: true
Skip-NLT: true
Skip-unit-test-memcheck: true

Skip-func-test-el8: true
Skip-func-test-el9: true
Skip-func-test-leap15: false
Skip-fault-injection-test: true
Skip-test-el-9.6-rpms: true
Skip-test-el-9-rpms: true
Skip-func-hw-test: true
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-3764

@grom72 grom72 marked this pull request as ready for review May 6, 2026 19:24
@grom72 grom72 requested a review from a team as a code owner May 6, 2026 19:24
@grom72 grom72 added the approved-to-merge PR has received release branch merge approval label May 6, 2026
Copy link
Copy Markdown
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't believe we want to use the daos-stack/pipeline-lib#512 change due to the potential impact to all branches.

Instead, couldn't we keep the stage name change here, but pass ' --build-arg POINT_RELEASE=.5 ' as an additionalBuildArgs to dockerfile().

In addition, we would need the ability to pass a "15.5" to buildRpm() to override the current parseSatgeInfo['distro_version'], but that's fairly easy with something like:

    Map stage_info = parseStageInfo(config)
    String target = config.get('target', stage_info['target'])
    String distro_version = config.get('distro_version', stage_info['distro_version'])
    ...
    String env_vars = ''
    env_vars = ' TARGET=' + target +
               ' DISTRO_VERSION=' + distro_version

Copy link
Copy Markdown
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recant my previous objection.

@phender
Copy link
Copy Markdown
Contributor

phender commented May 7, 2026

I still don't believe we want to use the daos-stack/pipeline-lib#512 change due to the potential impact to all branches.

Instead, couldn't we keep the stage name change here, but pass ' --build-arg POINT_RELEASE=.5 ' as an additionalBuildArgs to dockerfile().

In addition, we would need the ability to pass a "15.5" to buildRpm() to override the current parseSatgeInfo['distro_version'], but that's fairly easy with something like:

    Map stage_info = parseStageInfo(config)
    String target = config.get('target', stage_info['target'])
    String distro_version = config.get('distro_version', stage_info['distro_version'])
    ...
    String env_vars = ''
    env_vars = ' TARGET=' + target +
               ' DISTRO_VERSION=' + distro_version

Please ignore. The pipeline-lib change only affects release/2.6.

Comment thread Jenkinsfile
// To use a test branch (i.e. PR) until it lands to master
// I.e. for testing library changes
//@Library(value='pipeline-lib@your_branch') _
@Library(value='pipeline-lib@grom72/SRE-3764') _
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to remove this first before landing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-to-merge PR has received release branch merge approval

Development

Successfully merging this pull request may close these issues.

3 participants