You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move away from semantic versioning, and simplify release process.
The rationale is that we get very little benefit by using SemVer, because backwards compatibility isn't really applicable to us: there is no state, and users just want to be on the latest. It could be argued we don't need versions, and could just use a commit hash instead. I think versions help by making it clear how far behind one is to latest.
NOTE: Only seth cause it's a draft, but the same would apply for other tools.
The version number patching happening in Nix means this doesn't support make-based builds, /cc @rainbreak.
Would be nice if the --version output both the version number and the commit hash. This would help with 1) easy checkout and 2) disambiguation if I build locally from an unbumped development version.
I think --version is more expected from other cli tools, so it should at least alias to version (e.g. git allows both). Also we have seth --to-wei etc. as commands rather than flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move away from semantic versioning, and simplify release process.
The rationale is that we get very little benefit by using SemVer, because backwards compatibility isn't really applicable to us: there is no state, and users just want to be on the latest. It could be argued we don't need versions, and could just use a commit hash instead. I think versions help by making it clear how far behind one is to latest.
NOTE: Only
sethcause it's a draft, but the same would apply for other tools.The version number patching happening in Nix means this doesn't support make-based builds, /cc @rainbreak.