Remove synchronization from key press handling#53
Merged
Lakritzator merged 1 commit intomasterfrom Mar 26, 2026
Merged
Conversation
Removed synchronization and current thread observation for key press handling.
Member
Author
|
If this works I will also fix this for mouse events |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the .Synchronize() and .ObserveOn(Scheduler.CurrentThread) operators from the KeyboardHook observable chain. These changes ensure that keyboard events are processed synchronously on the hook thread, which is necessary for the Handled property to correctly suppress key propagation. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed synchronization and current thread observation for key press handling.
This should fix issues when applications try to handle a key combination and prevent it to go on to other applications or the operating system.
This fix was suggested by Gemini, and the bug was found in greenshot/greenshot#1116