Drop temporary android-sample clone pin#1
Open
phwizard wants to merge 1 commit into
Open
Conversation
sample-android PR #1 (tf/setup-integration-and-ux-fixes) merged on 2026-05-08, so the pin now clones a frozen pre-merge state. The sample's Setup-tab → BuildConfig wiring + .env policy that this pin was protecting is on main now, so default-branch clone is correct again. Other SDK targets (swift, reactjs, reactnative, wordpress) already use the default branch via the optional `branch?` field — this just removes the android-specific override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ethora setupat the mergedtf/setup-integration-and-ux-fixesbranch in ethora-sample-android.mainon 2026-05-08, so the pin now clones a frozen pre-merge state and the CLI's.envkeys are once again actively read bymain.branch:override on theandroidSDK_REPOS entry. Other targets (swift, reactjs, reactnative, wordpress) already use default-branch clones via the same optionalbranch?field.Test plan
npm run buildclean (done)ethora setup→ pick Android target → confirm clone command isgit clone https://github.com/dappros/ethora-sample-android.git ...with no-bflag.envfrom setup (BuildConfig wiring works on main)