Skip to content

fix: release DMG step fails because create-dmg native modules are never built #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arzafran merged 1 commit into from
Aug 28, 2026
Merged

fix: release DMG step fails because create-dmg native modules are never built #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/install-create-dmg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@ command -v "${BUN_COMMAND}" >/dev/null 2>&1 || {
--frozen-lockfile \
--ignore-scripts

# --ignore-scripts also skips the node-gyp builds that create-dmg's native
# dependencies need (macos-alias ships volume.node, fs-xattr ships xattr.node);
# without them appdmg fails with MODULE_NOT_FOUND at DMG creation. Rebuild only
# those two pinned packages so every other lifecycle script stays disabled.
NPM_COMMAND="${PROGRAMA_NPM_COMMAND:-npm}"
for native_package in macos-alias fs-xattr; do
package_dir="${INSTALL_DIR}/node_modules/${native_package}"
[[ -d "${package_dir}" ]] || continue
"${NPM_COMMAND}" rebuild --prefix "${INSTALL_DIR}" "${native_package}"
done

LOCAL_BIN="${INSTALL_DIR}/node_modules/.bin"
if [[ -n "${GITHUB_PATH:-}" ]]; then
printf '%s\n' "${LOCAL_BIN}" >> "${GITHUB_PATH}"
Expand Down
Loading