fix: split divider on dark themes (#26), browser downloads to ~/Downloads (#9), shellState dedup guard (#32)#45
Merged
Merged
Conversation
On near-black terminal backgrounds the computed divider was darkened toward black and vanished. Lighten dark backgrounds with an additive-brightness helper instead; light backgrounds still darken. An explicit split-divider-color override always wins. Adds GhosttyConfig divider tests.
shouldPublishShellActivity must not record the state it reads, or a report that never applies (panel absent) suppresses the next identical report and the activity update is lost. The fix is already on main; this regression guard locks it in.
Replace the NSSavePanel prompt on download completion with a direct move to ~/Downloads, appending " 2", " 3", … on filename collisions like Safari.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Three independent fixes bundled for the major bump:
split-divider-colorstill wins.~/Downloadsautomatically, with Safari-style " 2", " 3", … suffixes on name collisions.Summary
Sources/GhosttyConfig.swift:resolvedSplitDividerColorlightens (additive-brightnessNSColor.lighten(by:)) on dark backgrounds rather than darkening; light backgrounds keep thedarken(by: 0.08)path. Additive (not multiplicative) brightness so pure black still moves. ThreeGhosttyConfigTestscover dark-lighten, light-darken, and explicit-override.Sources/Panels/BrowserPanel.swift:BrowserDownloadDelegatereplaces theNSSavePanelflow withuniqueDownloadsURL(for:)+ a directmoveIteminto~/Downloads.cmuxTests/TerminalControllerShellStateDedupTests.swift(+project.pbxprojwiring): assertsSocketFastPathState.shouldPublishShellActivitydoes not record on read, so a never-applied report (panel absent) can't suppress the next identical report.Not in this PR
6cfd7045(PR feat: toggle to disable terminal scrollback persistence (#28) #36) as the "Save Scrollback on Quit" toggle. The applied patch re-implemented it from scratch unaware, producing a duplicateScrollbackPersistenceSettingsenum (redeclaration error), a second Settings toggle, and a localization-key collision. That redundant work was reverted; the existing No option to disable terminal scrollback persistence (privacy gap — sensitive output saved to disk) #28 implementation stands.Test Plan
./scripts/reload.sh --tag major-bumpbuilds clean (0 Swift errors)cmux-unit): divider lighten/darken/override (Split pane dividers are near-invisible by default (low-contrast darken factor) #26) + dedup guard (Add regression test for the #6618 shellState dedup race #32)Note: local CLI-helper / daemon zig steps require zig 0.15.2 (system has 0.16.0); the app builds via the prebuilt GhosttyKit cache. Full E2E runs on CI.