Skip to content

Fix chroma late_correction if temperature is disabled - #22832

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:late_correction_without_temp
Oct 29, 2026
Merged

TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:late_correction_without_temp

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator

Summary

If temperature module has been disabled for some reason we must not apply any late_correction factors.

Referenced issue

Fixes #22680
Fixes #22679

Checklist

  • I have read CONTRIBUTING.md and the coding style.
  • I have not merged master into the topic branch.
  • The pull request is one logical change, and every commit compiles on its own. You may use git rebase --exec 'cmake --build build master to check this.
  • A RELEASE_NOTES.md entry has not been added as clearly a cornercase if the user disabled temperature module.

If temperature module has been disabled for some reason we must not apply
any late_correction factors.
@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Oct 29, 2026
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: low core features work as expected, only secondary/optional features don't labels Oct 29, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit 36abf2d into darktable-org:master Oct 29, 2026
10 checks passed
@jenshannoschwalm
jenshannoschwalm deleted the late_correction_without_temp branch October 29, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: low core features work as expected, only secondary/optional features don't

Projects

None yet

2 participants