Skip to content

[interop] Add support for modules#446

Open
nikeokoronkwo wants to merge 5 commits into
dart-lang:mainfrom
nikeokoronkwo:interop/modules
Open

[interop] Add support for modules#446
nikeokoronkwo wants to merge 5 commits into
dart-lang:mainfrom
nikeokoronkwo:interop/modules

Conversation

@nikeokoronkwo

@nikeokoronkwo nikeokoronkwo commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

Fixes #424
Fixes #431

This PR adds support for TypeScript Modules, as well as TS Preprocessing, reference modules, and more!

@srujzs srujzs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a draft, so some of my comments may not apply. :)

Comment thread web_generator/lib/src/ast/base.dart
Comment thread web_generator/lib/src/ast/base.dart
Comment thread web_generator/lib/src/ast/declarations.dart
Comment thread web_generator/lib/src/ast/declarations.dart
Comment thread web_generator/lib/src/ast/declarations.dart
Comment thread web_generator/lib/src/interop_gen/transform/transformer.dart Outdated
Comment thread web_generator/lib/src/interop_gen/transform/transformer.dart Outdated
Comment thread web_generator/lib/src/interop_gen/transform/transformer.dart Outdated
@nikeokoronkwo nikeokoronkwo marked this pull request as ready for review August 30, 2025 18:25
@srujzs

srujzs commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

It looks like this is marked as ready for review. @nikeokoronkwo, should I take another pass?

@nikeokoronkwo

Copy link
Copy Markdown
Collaborator Author

It looks like this is marked as ready for review. @nikeokoronkwo, should I take another pass?

Sorry about that, not yet. I think I might have some changes I've not pushed, and I do not think global modules are supported yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interop Gen: Add support for TS Reference Compiler Directives Interop Gen: Support Modules

2 participants