[dwds] Use new hot restart API from embedder#2827
Open
nshahan wants to merge 10 commits into
Open
Conversation
nshahan
force-pushed
the
new-restart-logic
branch
2 times, most recently
from
67f4db1 to
bc334d5
Compare
Apply new formatter changes.
Start using the new `hotRestartBegin` and `hotRestartEnd` APIs from the embedder. These require the library bundle module system and allow for more customization in the integration of the hot restart operation. Specifically this allows for `$dartReloadModifiedModules` to decide which of the files provided from reloadedSources.json should actually be requested at this time and return the list of the actual requests so the restart logic in dwds knows what scripts it should await parse events for. Issue: #2826
nshahan
force-pushed
the
new-restart-logic
branch
from
bc334d5 to
e326143
Compare
Contributor
Author
|
NOTE: The first commit simply updates the SDK lower bound and applied the new Dart formatter. I suggest removing that first commit from the range when reviewing to make the changes easier to see. |
Markzipan
reviewed
May 18, 2026
srujzs
approved these changes
May 18, 2026
Markzipan
approved these changes
May 19, 2026
* Update the injected `$dartReloadModifiedModules` method to return the descriptors for the scripts that were reloaded. * Bumps the min SDK constrain to support the two phase restart logic that requires the new API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start using the new
hotRestartBeginandhotRestartEndAPIs from the embedder.These require the library bundle module system and allow for more customization in the integration of the hot restart operation.
Specifically this allows for
$dartReloadModifiedModulesto decide which of the files provided from reloadedSources.json should actually be requested at this time and return the list of the actual requests so the restart logic in dwds knows what scripts it should await parse events for.loadStrategy.id == 'ddc-library-bundle'as a way to identify load strategies that handle library bundles.reloadedSourcesUrigetter to a new interface namedReloadableLoadStrategyso strategies that support this mechanism can be identified by a type test.events_amd_test.dartandevents_ddc_library_bundle_test.dartso they run in both Frontend Server and Build Daemon integration modes.$dartReloadModifiedModuleshas been updated. Migrate to an embedder API that exposes hot restart as two phases (begin and end) build#4928Issue: #2826