Skip to content

[dwds] Remove unconditional TLS certificate trust in ProxyServerAssetReader #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexLaroche wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

[dwds] Remove unconditional TLS certificate trust in ProxyServerAssetReader #2833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## 27.1.2-wip

- Remove the `badCertificateCallback` override in `ProxyServerAssetReader` that
unconditionally accepted any TLS certificate when `isHttps: true` was set.
Callers that need to trust a private CA should configure a `SecurityContext`
on the `HttpClient` themselves. (CWE-295)

## 27.1.1

- Fix deserialization errors appearing in the chrome console.
Expand Down
4 changes: 1 addition & 3 deletions dwds/lib/src/readers/proxy_server_asset_reader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ class ProxyServerAssetReader implements AssetReader {
..maxConnectionsPerHost = 200
..idleTimeout = const Duration(seconds: 30)
..connectionTimeout = const Duration(seconds: 30);
final client = isHttps
? IOClient(inner..badCertificateCallback = (cert, host, port) => true)
: IOClient(inner);
final client = IOClient(inner);
var url = '$scheme$host:$assetServerPort/';
if (root.isNotEmpty) url += '$root/';
final handler = proxyHandler(url, client: client);
Expand Down