Skip to content

feat: include producer metadata in per-message events#370

Merged
josevalim merged 1 commit into
dashbitco:mainfrom
yordis:yordis/add-producer-to-telemetry
Apr 7, 2026
Merged

feat: include producer metadata in per-message events#370
josevalim merged 1 commit into
dashbitco:mainfrom
yordis:yordis/add-producer-to-telemetry

Conversation

@yordis
Copy link
Copy Markdown
Contributor

@yordis yordis commented Apr 5, 2026

  • Per-message telemetry events were missing the `producer` field that batch-level events already had (added in Add the producer to the telemetry metadata #308), making it impossible to correlate per-message spans back to their source producer
  • Without producer metadata, consumers of per-message telemetry events cannot populate OTel semantic convention attributes like `messaging.system` (derived from the producer module) and `messaging.destination.name` (from producer opts), which are required for meaningful span scoping in multi-producer pipelines

@yordis yordis force-pushed the yordis/add-producer-to-telemetry branch 2 times, most recently from 1512f1e to ebdbfb7 Compare April 5, 2026 16:15
Comment thread test/broadway/telemetry_test.exs Outdated
@yordis yordis requested a review from josevalim April 6, 2026 16:57
@yordis yordis force-pushed the yordis/add-producer-to-telemetry branch 2 times, most recently from 144f64f to 6bc0839 Compare April 6, 2026 17:11
Comment thread test/broadway_test.exs Outdated
@yordis yordis force-pushed the yordis/add-producer-to-telemetry branch from 6bc0839 to 7528d97 Compare April 7, 2026 17:16
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/add-producer-to-telemetry branch from 7528d97 to 79d432b Compare April 7, 2026 17:18
@yordis yordis requested a review from josevalim April 7, 2026 17:18
@josevalim josevalim merged commit dd2f405 into dashbitco:main Apr 7, 2026
2 checks passed
@josevalim
Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants