Skip to content

add association_type and evidence fields to STRchive-loci#332

Open
hdashnow wants to merge 9 commits intomainfrom
risk-alleles
Open

add association_type and evidence fields to STRchive-loci#332
hdashnow wants to merge 9 commits intomainfrom
risk-alleles

Conversation

@hdashnow
Copy link
Copy Markdown
Member

@hdashnow hdashnow commented Mar 12, 2026

Work in progress

Description

  • add association_type and evidence fields to STRchive-loci and schema
  • Check update loci form can access them
  • Auto-populate these from criTRia
  • Remove previous tags
  • Display these values in loci table and locus pages

Related issues:
#330

Major Changes

  • New locus or major change to existing locus e.g. pathogenic threshold, coordinate
  • New feature
  • New data field

Minor Changes

  • Minor change to existing locus e.g. new citation
  • Bug or gramatical error fix

Checklist

  • All changes are well summarized
  • Check all tests pass
  • Check that the website preview looks good
  • Update the STRchive version in CITATION.cff, format X.Y.Z. If any major changes, increment Y. If only minor changes, increment Z. If the breaking change (rare), increment X.
  • Ask someone to review this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 12, 2026

Deploy Preview for strchive ready!

Name Link
🔨 Latest commit 59dcc52
🔍 Latest deploy log https://app.netlify.com/projects/strchive/deploys/69cd592699fc760007f00c55
😎 Deploy Preview https://deploy-preview-332--strchive.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Macayla-weiner Macayla-weiner marked this pull request as ready for review April 1, 2026 16:51
@Macayla-weiner
Copy link
Copy Markdown
Contributor

CNBP, DIP2B, DMPK, FGF14, EIF4A3, FOXL2, GIPC1, JPH3, TYMS, and SOX3 need to be scored. So I'll get on that.

Compared to STRchive: MIR7 is backwards, the gene is MIR7-2 and the disease is CHNG3, C9orf72 the gene is listed as the full ID (FTDALS1_C9orf72) HOXA13-1_HFG should be HOXA13_HFG-1, and TNRC 6A shouldn't have a space.

Also, CSNK1E doesn't seem to have an STRchive page and ZIC3 in twice.

@hdashnow
Copy link
Copy Markdown
Member Author

hdashnow commented Apr 1, 2026

CNBP, DIP2B, DMPK, FGF14, EIF4A3, FOXL2, GIPC1, JPH3, TYMS, and SOX3 need to be scored. So I'll get on that.

No rush if you want to save this for the next PR.

Compared to STRchive: MIR7 is backwards, the gene is MIR7-2 and the disease is CHNG3, C9orf72 the gene is listed as the full ID (FTDALS1_C9orf72) HOXA13-1_HFG should be HOXA13_HFG-1, and TNRC 6A shouldn't have a space.

Also, CSNK1E doesn't seem to have an STRchive page and ZIC3 in twice.

Thanks! I'll fix these.

@hdashnow
Copy link
Copy Markdown
Member Author

hdashnow commented Apr 1, 2026

Okay @Macayla-weiner, I've fixed everything except CSNK1E because adding a new STRchive locus is a little more involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants