Skip to content

udpate schema generation and adde NLOD license to datasets - #67

Open
pernillehofgaard wants to merge 1 commit into
mainfrom
feat/update-schema-generation
Open

pernillehofgaard wants to merge 1 commit into
mainfrom
feat/update-schema-generation

Conversation

@pernillehofgaard

@pernillehofgaard pernillehofgaard commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description

update schema generation and added NLOD license to datasets

Documentation

  • Doc updated
  • Tested

Summary by CodeRabbit

  • New Features
    • Added Norwegian License for Open Government Data metadata to Brønnøysund Register Centre evidence definitions.
    • Improved JSON schema generation for selected registration and financial response data.
  • Documentation
    • Evidence definitions now clearly identify the applicable data license, helping users understand usage and reuse terms.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f49e56e4-e8e9-4acd-be5c-9169072c4f47

📥 Commits

Reviewing files that changed from the base of the PR and between 1925cdb and 214b265.

📒 Files selected for processing (12)
  • src/Dan.Plugin.Brreg/AnnualFinancialReport.cs
  • src/Dan.Plugin.Brreg/CertificateOfRegistration.cs
  • src/Dan.Plugin.Brreg/Ektepakt.cs
  • src/Dan.Plugin.Brreg/Frivillighetsregisteret.cs
  • src/Dan.Plugin.Brreg/Kunngjoringer.cs
  • src/Dan.Plugin.Brreg/Losore.cs
  • src/Dan.Plugin.Brreg/Registerutskrift.cs
  • src/Dan.Plugin.Brreg/Regnskapsregisteret.cs
  • src/Dan.Plugin.Brreg/Roller.cs
  • src/Dan.Plugin.Brreg/Stotteregisteret.cs
  • src/Dan.Plugin.Brreg/Tilskuddsregisteret.cs
  • src/Dan.Plugin.Brreg/UnitBasicInformation.cs

Walkthrough

The change adds the NLOD 2.0 license URL to multiple Brreg evidence definitions and standardizes selected JSON schema generation through EvidenceValue.SchemaFromObject.

Changes

Evidence definition updates

Layer / File(s) Summary
Standardize JSON schema generation
src/Dan.Plugin.Brreg/Ektepakt.cs, src/Dan.Plugin.Brreg/Losore.cs, src/Dan.Plugin.Brreg/Roller.cs
Selected default evidence values now generate schemas with EvidenceValue.SchemaFromObject, and obsolete NJsonSchema imports are removed.
Add license metadata to evidence definitions
src/Dan.Plugin.Brreg/AnnualFinancialReport.cs, src/Dan.Plugin.Brreg/CertificateOfRegistration.cs, src/Dan.Plugin.Brreg/Frivillighetsregisteret.cs, src/Dan.Plugin.Brreg/Kunngjoringer.cs, src/Dan.Plugin.Brreg/Losore.cs, src/Dan.Plugin.Brreg/Registerutskrift.cs, src/Dan.Plugin.Brreg/Regnskapsregisteret.cs, src/Dan.Plugin.Brreg/Stotteregisteret.cs, src/Dan.Plugin.Brreg/Tilskuddsregisteret.cs, src/Dan.Plugin.Brreg/UnitBasicInformation.cs
Affected EvidenceCode definitions now set the NLOD 2.0 license URL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: erlendoksvoll

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main changes: updated schema generation and added NLOD licenses to datasets.
Docstring Coverage ✅ Passed Docstring coverage is 20.00% which is sufficient. The required threshold is 0.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/update-schema-generation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant