Update advanced templates to use schemas#192
Conversation
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
dhruv0811
left a comment
dhruv0811
left a comment
There was a problem hiding this comment.
Left some comments!
A little confused about what we want the default behavior to look like now? Custom schema out of the box, or is it opt-in?
There was a problem hiding this comment.
Commenting as a reminder to remove after #415 gets merged
| keyword in error_msg | ||
| for keyword in ["lakebase", "pg_hba", "postgres", "database instance", "insufficient privilege"] | ||
| ): | ||
| logger.error("Lakebase access error during session setup:\n%s", get_lakebase_access_error_message(lakebase_config.description)) |
There was a problem hiding this comment.
Can we delete get_lakebase_access_error_message now as well?
There was a problem hiding this comment.
Also, this error message was useful because it directed users to the grant script. They dont need the script anymore for agent memory, but they still do need it for UI drizzle schemas right? So maybe the new error message should still keep some of the content from get_lakebase_access_error_message?
dhruv0811
left a comment
dhruv0811
left a comment
There was a problem hiding this comment.
also lgtm!
Just need to wait for other PR merge :)
jennsun
left a comment
jennsun
left a comment
There was a problem hiding this comment.
ty for updating the agent memory examples w/ updated schemas! could you add testing to verify this works (deploy an agent and make sure without running the permission granting script, the short-term/long-term memory checkpoints and user preferences are now in the custom schema
3 participants
relies on databricks/databricks-ai-bridge#415