Remove redundant base_parameters from Vector Search example jobs#159
Merged
Conversation
Job-level parameters are automatically pushed down to notebook tasks and read via dbutils.widgets.get(), and job parameters take precedence over same-key task parameters anyway, so mirroring them through base_parameters had no effect. Follow-up to review feedback on #153.
pietern
approved these changes
Jun 12, 2026
pietern
left a comment
pietern
left a comment
Contributor
There was a problem hiding this comment.
I recommend to omit base_parameters entirely, if you don't know about them, you don't have to at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to review feedback on #153: job-level
parametersare automatically pushed down to notebook tasks, so thebase_parametersblocks that mirrored them 1:1 via{{job.parameters.x}}were redundant.Confirmed against the docs (Parameterize jobs, Access parameter values from a task):
dbutils.widgets.get()— which is exactly how01_upsert_products.pyand02_query_demo.pyalready read them.base_parameterscould never take effect anyway; removing them is behavior-preserving.databricks bundle validatepasses for both targets against a real workspace (dev and prod, host placeholder swapped locally for validation only).This pull request and its description were generated with Claude Code.