-
Notifications
You must be signed in to change notification settings - Fork 125
internal: structaccess: support key-value syntax; add NotFoundError #4204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+213
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
approved these changes
Jan 6, 2026
Collaborator
|
Commit: 1747da8
24 interesting tests: 21 KNOWN, 2 FAIL, 1 SKIP
Top 43 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Jan 6, 2026
Collaborator
|
Commit: 52cb1a7
41 interesting tests: 21 KNOWN, 14 FAIL, 3 MISS, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik
added a commit
that referenced
this pull request
Jan 7, 2026
Follow up to #4204 NotFoundError is meant for cases where path is correct for a given type but value is not there. nil struct is such case. This also simplifies test cases. We don't need hasTypeError flag anymore, because notFoundError already implies hasTypeError=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tasks[task_key='foo']) in structaccess.Get() and Set()Why
Completeness. Using this features in #4201
Tests
Unit tests.