Fix script output dropping last line without trailing newline#4995
Open
Fix script output dropping last line without trailing newline#4995
Conversation
denik
added a commit
that referenced
this pull request
Apr 16, 2026
Approval status: pending
|
bufio.Reader.ReadString returns both data and io.EOF when the stream ends without a delimiter. The old loop condition `for err == nil` caused the last line of output to be silently dropped when it lacked a trailing newline. This affected any bundle script (experimental.scripts hooks) whose output didn't end with `\n`. Restructure the loop to always process data before checking for errors, which is the idiomatic Go pattern for ReadString. Task: 001.md Co-authored-by: Isaac
Co-authored-by: Isaac
This test demonstrates the bug where the last line of script output was dropped when it didn't end with a trailing newline. Running this test with -useversion 0.296.0 shows the bug: "line without newline" is missing from the output. Task: 002.md Co-authored-by: Isaac
a86395c to
f43f4d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix
experimental.scriptshooks silently dropping the last line of output when it doesn't end with a trailing newline (e.g.printf "done").Tests
Added acceptance test at
acceptance/bundle/scripts/no-trailing-newline/and unit tests for the script executor.Running the acceptance test against the previous release demonstrates the bug:
v0.296.0 drops "line without newline" because the last line has no trailing
\n. The fix correctly includes it.