-
Notifications
You must be signed in to change notification settings - Fork 161
Replace Makefile with Taskfile.yml and move all generation-related logic there #5050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
117d45e
a4ace47
6f27057
5dc976e
8620289
9f2873a
008400a
a9b1fba
a5fb2b2
4d37268
761a36d
ee27be6
23f93a0
dcc8150
8a76d24
654a96d
c5097f6
23051bc
a3431df
63c4c0b
2564a7a
63b574f
4358d7a
39667a6
c843230
ae1f726
3e96e29
a9d88d2
2642025
564ecda
1f935a5
7e0dc9c
6f920d8
d155086
bb5fae3
039a4b8
2010a47
2134a5a
4d19c6b
c7cc94c
9d16402
ed7da79
2457e0c
f67fdf1
d3a301b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,9 +12,6 @@ | |
| "toolchain": { | ||
| "required": [ | ||
| "go" | ||
| ], | ||
| "post_generate": [ | ||
| "./tools/post-generate.sh" | ||
| ] | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,15 +32,19 @@ jobs: | |
| - name: Checkout repository and submodules | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0 | ||
| with: | ||
| python-version: ${{ matrix.pyVersion }} | ||
| version: "0.6.5" | ||
|
|
||
| - name: Run tests | ||
| working-directory: python | ||
| run: make test | ||
| run: ./task pydabs-test | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Gap (Major)] Python PR CI no longer reruns when the shared task runner changes This job runs A PR that edits only Suggested fix: expand paths:
- python/**
- Taskfile.yml
- task
- tools/task/**
- tools/lintdiff.py # pydabs-lint indirectly depends on it
- .github/workflows/python_push.yml # self-retriggerFound by: Cursor (R1), Confirmed by: Isaac (R2) |
||
|
|
||
| python_linters: | ||
| name: lint | ||
|
|
@@ -50,14 +54,18 @@ jobs: | |
| - name: Checkout repository and submodules | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0 | ||
| with: | ||
| version: "0.6.5" | ||
|
|
||
| - name: Run lint | ||
| working-directory: python | ||
| run: make lint | ||
| run: ./task pydabs-lint | ||
|
|
||
| python_docs: | ||
| name: docs | ||
|
|
@@ -67,11 +75,15 @@ jobs: | |
| - name: Checkout repository and submodules | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0 | ||
| with: | ||
| version: "0.6.5" | ||
|
|
||
| - name: Run docs | ||
| working-directory: python | ||
| run: make docs | ||
| run: ./task pydabs-docs | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,17 +28,28 @@ __pycache__ | |
|
|
||
| .ruff_cache | ||
|
|
||
| # Test results from 'make test' | ||
| # Test results from 'task test' | ||
| test-output.json | ||
| test-output-unit.json | ||
| test-output-unit-root.json | ||
| test-output-unit-tools.json | ||
| test-output-unit-codegen.json | ||
| test-output-acc.json | ||
|
|
||
| # Built by make for 'make fmt' and yamlcheck.py in acceptance tests | ||
| # Taskfile cache | ||
| .task/ | ||
|
|
||
| # Snapshot binary from 'task snapshot' | ||
| .databricks/ | ||
|
|
||
| # Built for 'task fmt' and yamlcheck.py in acceptance tests | ||
| tools/yamlfmt | ||
| tools/yamlfmt.exe | ||
|
|
||
| # Built by make for 'make lint' | ||
| # Built for 'task lint' | ||
| tools/golangci-lint | ||
|
|
||
| # Built by make for test filtering | ||
| # Built for test filtering | ||
| tools/testmask/testmask | ||
|
|
||
| # Cache for tools/gh_report.py | ||
|
|
@@ -50,6 +61,7 @@ dist/ | |
| # Local development notes, tmp | ||
| /pr-* | ||
| /tmp/ | ||
| /.tmp/ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Nit]
Suggested fix: add an explanatory comment next to Found by: Isaac (R1) |
||
|
|
||
| # Go workspace file | ||
| go.work | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Major] CI error message tells developers to run a task that does not exist
This error message says
Run './task generate-out-test-toml' to update., but no such task exists inTaskfile.yml. The oldmain:Makefilehad it (go test ./acceptance -run '^TestAccept$$' -only-out-test-toml); it was dropped in the migration.Verified by running
./task generate-out-test-tomlon the PR branch: it exits 200 withTask does not exist.Developers who hit this CI failure will follow the message into a second error.(Also:
.agent/rules/auto-generated-files.mdon main mentionsmake generate-out-test-toml; that would route through.DEFAULTand hit the same dead end.)Suggested fix: port the
generate-out-test-tomltarget from the old Makefile intoTaskfile.yml(it's a one-linego testinvocation), and update agent docs if they still reference the old command.Found by: Isaac (cross-review, R2)