Skip to content

Archive gotestsum JSON for unit and acc tests #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pietern wants to merge 1 commit into
base: test-time-windows-skip
Choose a base branch
from
+16 −11
Draft

Archive gotestsum JSON for unit and acc tests #5068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,17 @@ jobs:
ENVFILTER: DATABRICKS_BUNDLE_ENGINE=${{ matrix.deployment }}
run: make cover

- name: Analyze slow tests
run: make slowest
- name: Upload gotestsum JSON output
# Always upload so we can inspect timing even if tests fail.
if: ${{ always() }}
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
with:
name: test-output-${{ matrix.os.name }}-${{ matrix.deployment }}
path: |
test-output-unit.json
test-output-acc.json
if-no-files-found: warn
retention-days: 7

- name: Check out.test.toml files are up to date
shell: bash
Expand Down
14 changes: 5 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ACCEPTANCE_TEST_FILTER = ""

GO_TOOL ?= go tool -modfile=tools/go.mod
GOTESTSUM_FORMAT ?= pkgname-and-test-fails
GOTESTSUM_CMD ?= ${GO_TOOL} gotestsum --format ${GOTESTSUM_FORMAT} --no-summary=skipped --jsonfile test-output.json --rerun-fails
GOTESTSUM_CMD ?= ${GO_TOOL} gotestsum --format ${GOTESTSUM_FORMAT} --no-summary=skipped --rerun-fails
LOCAL_TIMEOUT ?= 30m


Expand Down Expand Up @@ -79,11 +79,11 @@ test: test-unit test-acc

.PHONY: test-unit
test-unit:
${GOTESTSUM_CMD} --packages "${TEST_PACKAGES}" -- -timeout=${LOCAL_TIMEOUT}
${GOTESTSUM_CMD} --jsonfile=test-output-unit.json --packages "${TEST_PACKAGES}" -- -timeout=${LOCAL_TIMEOUT}

.PHONY: test-acc
test-acc:
${GOTESTSUM_CMD} --packages ./acceptance/... -- -timeout=${LOCAL_TIMEOUT} -run ${ACCEPTANCE_TEST_FILTER}
${GOTESTSUM_CMD} --jsonfile=test-output-acc.json --packages ./acceptance/... -- -timeout=${LOCAL_TIMEOUT} -run ${ACCEPTANCE_TEST_FILTER}

# Updates acceptance test output (local tests)
.PHONY: test-update
Expand All @@ -108,15 +108,11 @@ test-update-aws:
.PHONY: test-update-all
test-update-all: test-update test-update-aws

.PHONY: slowest
slowest:
${GO_TOOL} gotestsum tool slowest --jsonfile test-output.json --threshold 1s --num 50

.PHONY: cover
cover:
rm -fr ./acceptance/build/cover/
VERBOSE_TEST=1 ${GOTESTSUM_CMD} --packages "${TEST_PACKAGES}" -- -coverprofile=coverage.txt -timeout=${LOCAL_TIMEOUT}
VERBOSE_TEST=1 CLI_GOCOVERDIR=build/cover ${GOTESTSUM_CMD} --packages ./acceptance/... -- -timeout=${LOCAL_TIMEOUT} -run ${ACCEPTANCE_TEST_FILTER}
VERBOSE_TEST=1 ${GOTESTSUM_CMD} --jsonfile=test-output-unit.json --packages "${TEST_PACKAGES}" -- -coverprofile=coverage.txt -timeout=${LOCAL_TIMEOUT}
VERBOSE_TEST=1 CLI_GOCOVERDIR=build/cover ${GOTESTSUM_CMD} --jsonfile=test-output-acc.json --packages ./acceptance/... -- -timeout=${LOCAL_TIMEOUT} -run ${ACCEPTANCE_TEST_FILTER}
rm -fr ./acceptance/build/cover-merged/
mkdir -p acceptance/build/cover-merged/
go tool covdata merge -i $$(printf '%s,' acceptance/build/cover/* | sed 's/,$$//') -o acceptance/build/cover-merged/
Expand Down