Remove stale staticcheck nolint directives for workspace methods#5573
Open
pietern wants to merge 1 commit into
Open
Remove stale staticcheck nolint directives for workspace methods#5573pietern wants to merge 1 commit into
pietern wants to merge 1 commit into
Conversation
These `//nolint:staticcheck // Deprecated in SDK v0.127.0` directives suppressed SA1019 on Workspace methods (GetStatusByPath, MkdirsByPath, ListAll, Delete, Mkdirs). The SDK marked these deprecated in v0.127.0, but reverted it in v0.129.0 (databricks/databricks-sdk-go#1644). We are now on v0.141.0, so the directives have been dead for many releases. Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: b599bd1
22 interesting tests: 15 SKIP, 7 KNOWN
Top 30 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 38 stale
//nolint:staticcheckdirectives across 21 files. They suppressed SA1019 onWorkspacemethods (GetStatusByPath,MkdirsByPath,ListAll,Delete,Mkdirs), which were erroneously marked deprecated in SDK v0.127.0 (databricks/databricks-sdk-go#1626) and un-deprecated one release later in v0.129.0 (databricks/databricks-sdk-go#1644). We're now on v0.141.0, so the directives are dead.This PR was written by Isaac.