bundle/config: flip workspace URL test to opt-out#5601
Open
janniklasrose wants to merge 1 commit into
Open
Conversation
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 31e2720
22 interesting tests: 15 SKIP, 7 RECOVERED
Top 30 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refactor
TestBundleResourcePluralNamesResolveInWorkspaceURLsfrom an opt-in list (withURLs, 22 entries) to an opt-out map (noURL, 5 entries). The test now iterates allSupportedResources()automatically and asserts every resource either resolves to a non-empty workspace URL or is explicitly listed as having no URL.Why
The opt-in approach required manually adding new resources to the test list, making it easy to silently miss coverage. The opt-out approach catches omissions by default: any new resource added to
SupportedResources()will fail the test unless it has a URL pattern inlibs/workspaceurlsor is explicitly opted out with a comment.As a bonus, the refactor surfaces that
genie_spaceswas already present inresourceURLPatternsbut had been inadvertently omitted from the oldwithURLslist.A staleness check guards the
noURLmap itself: if a resource is removed fromSupportedResources(), the test fails rather than silently carrying a dead opt-out entry.Tests
Existing test updated; runs as part of
./task test.This PR was written by Claude Code.