Repository navigation
Conversation
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
There was a problem hiding this comment.
🟡 Changes recommended
A required changelog fragment is missing, and declared-property behavior needs explicit regression coverage.
3 open findings
What changed in this PR
Broadens schema and catalog backend-default handling to ignore undeclared remote properties and prevent repeated empty updates.
Changes:
- Applies backend-default handling to entire properties maps.
- Adds coverage for remote-only schema and catalog properties.
| File | Description |
|---|---|
bundle/direct/dresources/configs/schemas.yml |
Broadens schema property handling. |
bundle/direct/dresources/configs/catalogs.yml |
Broadens catalog property handling. |
bundle/direct/bundle_plan_test.go |
Tests remote-only property suppression. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Changelog fragment .nextchanges/bundles/7036.md is on the current head. Local ./task check-changelog passes. The review ran on the prior commit before that file landed. |
|
Runtime check retry on LAB: live workspace schema count is 1 (workspace.information_schema). Create still returns QUOTA_EXCEEDED with estimated count 52, limit 50. Bind and deploy steps cannot run until the estimate refreshes. Local unit and lint results in the PR description are unchanged. |
|
Runtime check retry on LAB passed with the fixed binary. Created workspace.test6986_fixed_1791898212 with properties owner root, bound a bundle that declares no properties, first deploy reported 1 unchanged, second deploy reported 1 unchanged, plan reported 0 to change. Test schema deleted after the run. PR description Tests section updated to match. |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Changes
Broaden the backend defaults rule for schemas and catalogs from managed default keys only to the full properties map. Add a planner test for remote-only properties on both resources.
Why
A bound schema with properties set outside the bundle and no properties in config planned an Update on every deploy. The SDK omits empty maps, so the update never cleared the remote values and the next plan showed the same diff. Skipping the map when saved state and config both declare none stops the repeat Update. Declared keys still diff and update. Fixes #6986.
Tests
Added TestSchemaCatalogRemoteOnlyPropertiesSkipped, including declared cases that must not skip. It failed before the change and passes after. Ran go test ./bundle/... and golangci-lint on bundle/direct with no failures. Ran the fixed binary on a test workspace against a schema created with properties owner root and a bundle that declares no properties. Bind succeeded, first deploy reported 1 unchanged, second deploy reported 1 unchanged, and plan reported 0 to change. Test schema was deleted after the run.