Remove RemoteChunkProvider and EnableStreamingChunkProvider flag #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change EnableStreamingChunkProvider default value from 0 to 1, making StreamingChunkProvider the default for result fetching. This removes the experimental label as the implementation is now production-ready. - Update DatabricksJdbcUrlParams default from "0" to "1" - Update ArrowStreamResultTest to verify default behavior - Test that explicitly disabling still uses RemoteChunkProvider
StreamingChunkProvider is now the only remote chunk provider implementation. Changes: - Delete RemoteChunkProvider.java and ChunkDownloadTask.java - Delete RemoteChunkProviderTest.java and ChunkDownloadTaskTest.java - Remove EnableStreamingChunkProvider param from DatabricksJdbcUrlParams - Remove isStreamingChunkProviderEnabled() from connection context - Simplify ArrowStreamResult to always use StreamingChunkProvider - Update integration tests to use ChunkProvider interface with iteration Note: AbstractRemoteChunkProvider is kept for RemoteChunkProviderV2 (incubator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
StreamingChunkProvider is now the only remote chunk provider implementation.
Changes:
Note: AbstractRemoteChunkProvider is kept for RemoteChunkProviderV2 (incubator)
Description
Testing
Additional Notes to the Reviewer