Regenerate SDK for universe naming-audit renames#210
Draft
parthban-db wants to merge 1 commit into
Draft
Conversation
parthban-db
force-pushed
the
parthban-db/stack/fix-as-many-possible
branch
from
35e46f3 to
4672015
Compare
Regenerated output of https://github.com/databricks-eng/universe/pull/2069359: last 20 request DTOs gain Request suffixes, 101 nested Outer_Inner types flatten to top-level names, and stem-symmetry fixes land (deleteProject -> deleteRepo, getCommandStatus, CreateInstallationRequest, ListTransitionRequests, etc.). 68 files across ~30 packages; build, lint, and tests green. Co-authored-by: Isaac
parthban-db
force-pushed
the
parthban-db/stack/fix-as-many-possible
branch
from
4672015 to
fe03223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
Regenerated SDK output of https://github.com/databricks-eng/universe/pull/2069359 — the strictly-easy remainder of the naming audit (#128). The regen runs against latest universe master, so it also picks up the renames from the just-merged https://github.com/databricks-eng/universe/pull/2018176 (networking CustomerFacing* drops). ~35 files; pure renames, no wire-shape change.
Why
The naming audit found the SDK leaking proto idioms into TypeScript: verb-phrase request types (
InstallListing) and request/response/method stem mismatches (most visiblycreateRepo, getRepo, listRepos, updateRepo, deleteProject). The upstream universe PR fixes these at the source via sanctionedopenapi_namesannotations; this PR previews and CI-validates the regenerated surface. Do not merge before the universe PR lands and the regular SDK-update automation picks it up.What changed
Interface changes
Requestsuffix gain one, stem-matched to their responses (e.g.InstallListing→CreateInstallationRequest, matching the existingCreateInstallationResponse;CreateIpAccessList→CreateIpAccessListRequest;UpdateToken→UpdateTokenRequest;RetrieveToken→RetrieveTokenRequest).deleteProject→deleteRepo,commandStatus/contextStatus→getCommandStatus/getContextStatus,listQuota→listQuotas,listEndpoint→listEndpoints,listTransitionsRequest→listTransitionRequests,QueryEndpointInputRequest→QueryEndpointRequest,GenieStartConversationMessageRequest→GenieStartConversationRequest,GetPermissionLevelsResponse→ListPermissionLevelsResponse,GetWorkspacePermissionAssignmentsResponse→ListWorkspacePermissionAssignmentsResponse.Behavioral changes
None — pure renames; the wire format and runtime behavior are untouched.
Internal changes
None beyond the generated model/client/index files.
How is this tested?
npm run build,npm run lint, andnpm testall pass on the regenerated tree. Upstream, the universe PR passedbazel test //deco/public_proto/...(677 tests), the protobuf linter in diff mode, and localruntests --test_type all; the rebuilt descriptor was grepped to confirm old names are gone. Every new name is grounded in the proto's existinglegacy_name, the live sdk-go surface, or stem symmetry with already-shipped names.NO_CHANGELOG=true