mcp: add ucode mcp remove to unregister configured MCP servers - #351
Open
sunishsheth2009 wants to merge 2 commits into
Open
mcp: add ucode mcp remove to unregister configured MCP servers#351sunishsheth2009 wants to merge 2 commits into
ucode mcp remove to unregister configured MCP servers#351sunishsheth2009 wants to merge 2 commits into
Conversation
Completes the `ucode mcp <verb>` set alongside `ucode mcp add`. `ucode mcp remove` shows the MCP servers you currently have configured — each with the coding tools it's registered on — and unregisters the ones you select from those tools. It's interactive only (no flags), never touches skills connections (owned by `configure skills`), and needs no Databricks login: unregistering a server is purely local, so it works even when the workspace token has expired (setup_mcp_clients grows a `require_auth` toggle for this).
Skills get a separate docs update later; don't reference the skills relationship in the README or CLI --help here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
ucode mcp remove, completing theucode mcp <verb>set alongside the recently-mergeducode mcp add(#340).ucode mcp removeshows the MCP servers you currently have configured — each annotated with the coding tools it's registered on — and unregisters the ones you select from those tools.Design
--location/--services/--allflags. Removal is a small, destructive operation where seeing the concrete list (and which tools each server is on) before selecting is the safer UX.ucode configure skills, matching how theconfigure mcp/addpickers already treat them.claude mcp removeand friends), so it works even when the workspace token has expired.setup_mcp_clientsgrows arequire_authtoggle for this; the add/configure paths keep forcing auth as before.Removal targets each server's recorded clients (via the existing
apply_mcp_server_changesremove path), so a server registered on a tool that isn't currently configured is still cleaned up.Changes
src/ucode/mcp.py:remove_mcp_command(),_prompt_for_mcp_removal(), and arequire_auth/action_notetoggle onsetup_mcp_clients.src/ucode/cli.py:@mcp_app.command("remove").README.md: documentsucode mcp remove.tests/test_mcp.py:TestRemoveMcpCommand(removes selection, cancel = no-op, skills excluded, empty config skips the picker) + a picker-rendering test.Testing
uv run ruff format/ruff check,uv run ty check src/, anduv run pytestall pass (the only failures are the two pre-existing network-dependenttest_e2e_user_agenttests).This pull request and its description were written by Isaac.