Repository navigation
Conversation
Author
|
Superseded by #132, containing the same changes on an upstream branch. The fork PR's CI could not obtain the required OIDC permissions and the doc-inventory job expected an upstream branch. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid polygons can produce mixed GeometryCollections when clipped against a BNG cell boundary. The Scala tier calls JTS
differencedirectly on the collection and raisesOperation does not support GeometryCollection arguments. The Python tier accepts the operation, but can retain boundary-only points and then silently discard the cell through an exact geometry-type filter. Polygon-to-MultiPolygon clipping also loses cells in both original implementations.Scala changes:
JTS.intersectionandJTS.differencehelpers that recursively handle mixed collections on either side, compact results through unary union, and preserve the left SRID and factory. Ordinary geometries retain existing JTS overlay operations.JTS.implicits._extensions and usecollectionAwareIntersection/collectionAwareDifferencein BNG tessellation.Python changes:
_clean_chip_geometryin_bng.pyto subtract cell boundaries from individual collection leaves, discard empty results, and compact surviving members while preserving SRID. Ordinary clips remain unchanged to preserve vertex order for core-cell promotion.Validation:
General overlay helpers retain legitimate lines and points; dimension filtering remains in tessellation. Broader migration of direct JTS callers is outside this change. All regression geometries are synthetic; no customer data is included.