-
Notifications
You must be signed in to change notification settings - Fork 115
Update autopush nodejs goldens #5878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @clincoln8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the golden files used by the Node.js query differ. These changes are necessary to synchronize the expected output with recent data refreshes or minor adjustments in data generation logic, ensuring the system reflects the most current statistical information for Santa Clara County job categories and obesity prevalence. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the golden files for the autopush nodejs query tests, reflecting new data from the backend service. My review focuses on improving the clarity and maintainability of this test data. I've identified a potential ambiguity in a chart title's date representation and suggested reducing the precision of floating-point numbers to enhance readability and reduce diff noise. These are suggestions to consider for the data generation process.
| "Mining, Quarrying, Oil and Gas Extraction Industry Workers" | ||
| ], | ||
| "title": "Categories of Jobs in Santa Clara County (Jan, 2024 to Mar, 2024)", | ||
| "title": "Categories of Jobs in Santa Clara County (Mar, 2025)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date format in the title has changed from a range (Jan, 2024 to Mar, 2024) to a single month (Mar, 2025). Given that the data source is BLS QCEW, which provides quarterly data, representing the data for a single month could be misleading. For clarity and accuracy, consider using a format that reflects the quarterly nature of the data, such as 'Q1 2025' or 'Jan 2025 - Mar 2025'.
| }, | ||
| { | ||
| "dataCsv": "label,Prevalence of Obesity\r\n2022,28.376914631938966\r\n2021,28.7622100905209\r\n2020,28.991059890577457\r\n2018,26.538281101665365\r\n2017,24.74933215552956\r\n2016,24.878941888621984\r\n2015,24.359457072888013\r\n2014,24.726810930702747", | ||
| "dataCsv": "label,Prevalence of Obesity\r\n2022,28.369354377079862\r\n2021,28.762210090520888\r\n2020,28.98887666412878\r\n2018,26.533458367011427\r\n2017,24.749332155529583\r\n2016,24.878941888621974\r\n2015,24.359457072888013\r\n2014,24.72681093070274", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The floating-point values for 'Prevalence of Obesity' have a very high precision (up to 15 decimal places). This level of precision is likely not meaningful for this metric and can introduce noise in future diffs due to minor floating-point variations. Consider rounding these values to a more reasonable number of decimal places (e.g., 2 to 4) in the data generation process. This would improve readability and the stability of the golden files.
No description provided.