-
Notifications
You must be signed in to change notification settings - Fork 115
Mock datetime to fix python unit tests for the new year #5879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @clincoln8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a failing unit test in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a date-dependent unit test by mocking datetime.date.today() to a fixed date, ensuring the test remains stable over time. The approach is correct. I've added one suggestion to improve consistency with other tests in the same file by patching datetime.date more specifically.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a date-dependent unit test by mocking datetime. The change is well-implemented and includes a clear comment explaining the purpose of the mock. Additionally, another test was updated for consistency, which is a good practice. I've added a couple of suggestions to reorder the @patch decorators to improve code readability and maintainability by making the order of mock arguments in the function signature match the visual order of the decorators.
Fix Date-Dependent Test: Patched datetime for
test_fetch_highest_coverage_with_entities_single_variableinserver/tests/lib/util_test.pyto freeze the date to 2025-01-01. This ensures 2021 test data remains within the 5-year "recent" window check, preventing data age-out failures.