fix: recover malformed JSON arguments in write_file tool calls#212
Open
jigangz wants to merge 1 commit intodataelement:mainfrom
Open
fix: recover malformed JSON arguments in write_file tool calls#212jigangz wants to merge 1 commit intodataelement:mainfrom
jigangz wants to merge 1 commit intodataelement:mainfrom
Conversation
When LLMs produce slightly malformed JSON (trailing commas, etc.), the argument parser silently falls back to empty args, causing write_file to report 'missing path' even when the path was provided. This adds: 1. Detailed logging of JSON parse errors with raw content 2. Fallback cleanup (strip trailing commas) before giving up 3. Better error visibility for debugging Fixes dataelement#177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
write_filetool reporting 'missing path' even when the path parameter is explicitly provided by the LLM.Problem
When LLMs produce slightly malformed JSON arguments (e.g. trailing commas),
json.loads()fails silently and falls back toargs = {}. The empty-args guard then returns an error to the LLM saying the path is missing, even though the LLM did provide it.Changes
}or]) before giving upTesting
Fixes #177