fix: persist username changes in account settings (PATCH /auth/me)#213
Open
jigangz wants to merge 1 commit intodataelement:mainfrom
Open
fix: persist username changes in account settings (PATCH /auth/me)#213jigangz wants to merge 1 commit intodataelement:mainfrom
jigangz wants to merge 1 commit intodataelement:mainfrom
Conversation
The endpoint used db.flush() which writes to the DB transaction buffer but relies on the dependency cleanup to commit. If the response serialization happens before the commit, or if the session's expire_on_commit=False prevents refresh, the returned user object may not reflect the persisted state. This changes to explicit commit() + refresh() to ensure: 1. Changes are persisted immediately 2. The returned UserOut reflects the committed state 3. Server-side fields (updated_at) are properly populated Fixes dataelement#205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix username changes not being saved in the Account Settings modal.
Problem
The
PATCH /auth/meendpoint useddb.flush()instead ofdb.commit(). Whileflush()writes to the transaction buffer, the actual commit depends on theget_db()dependency cleanup which runs after the response is sent. Combined withexpire_on_commit=False, this can result in:updated_at)Changes
db.flush()withdb.commit()for explicit persistencedb.refresh(current_user)to ensure the returned object reflects committed stateTesting
Fixes #205