Skip to content

fix(enterprise): persist llm model temperature in create and update APIs#253

Closed
zfaustk wants to merge 3 commits intodataelement:mainfrom
zfaustk:fix/enterprise-llm-model-persistence
Closed

fix(enterprise): persist llm model temperature in create and update APIs#253
zfaustk wants to merge 3 commits intodataelement:mainfrom
zfaustk:fix/enterprise-llm-model-persistence

Conversation

@zfaustk
Copy link
Copy Markdown

@zfaustk zfaustk commented Apr 1, 2026

Summary

Fixes #247 by persisting temperature in both enterprise LLM model write paths:

  • store temperature when creating /api/enterprise/llm-models
  • store temperature when updating /api/enterprise/llm-models/{model_id}
  • add focused regression coverage for both code paths

Validation

  • pytest tests/test_enterprise_llm_model_api.py

@wisdomqin
Copy link
Copy Markdown
Contributor

Thanks for the fix! The temperature persistence issue was a valid catch. We already have both changes (create + update paths) on main, so this PR is not needed for merge. We also noticed the test file path has an extra nesting level (tests/test_.../test_...). Appreciate the contribution!

@wisdomqin wisdomqin closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: LLM Model temperature field ignored in create/update API

2 participants