[codex] Fix /api/tools/bulk 422 caused by route matching#262
Open
39499740 wants to merge 1 commit intodataelement:mainfrom
Open
[codex] Fix /api/tools/bulk 422 caused by route matching#26239499740 wants to merge 1 commit intodataelement:mainfrom
39499740 wants to merge 1 commit intodataelement:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /api/tools/bulkreturning 422 when toggling tools in bulk from Company Settings/tools/bulkroute definition before the dynamic/{tool_id}route so FastAPI matches correctly/api/tools/bulkupdates tool states successfullyRoot Cause
PUT /api/tools/bulkwas being matched byPUT /tools/{tool_id}first, so"bulk"was validated as a UUID path parameter and failed with 422.Validation
cd backend && uv run --extra dev pytest -q tests/test_tools_bulk_api.py1 passedFixes #261