Repository navigation
Strictly parse complete Copilot JSON event streams - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45 repeatedly fails on a large Copilot stdout line at a stable JSON offset. The current parser assumes exactly one event per newline, although a stream can contain adjacent complete JSON objects.
Consume the entire event stream with a string/escape/bracket-aware scanner, then strictly JSON.parse every extracted object. Accept whitespace and adjacent complete objects; reject all garbage, mismatched or incomplete structures. Keep final-model, tool/MCP restrictions, unique final answer and successful result checks. Syntax diagnostics expose only structural types and character positions/codes, and no longer misclassify words inside JSON source evidence as rate limiting.
Validation: catalog validation and 100 tests pass, including NDJSON/adjacent objects, escaped quotes and braces in strings, trailing garbage, incomplete structures and forbidden tool events. Real PR #45 will be rechecked after merge; this does not bypass its safety judgments.