Repository navigation
Keep complete package review requests small with exact deduplication - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45's large CLI event repeatedly contains malformed output at the same material batch, including a non-JSON right parenthesis. Strict parsing correctly rejects it; no output bytes are ignored or treated as approval.
Reduce evidence slices to 40k characters with 2k overlap, limit serialized evidence to 150k and complete requests to 230k. Deduplicate only whole files with equal SHA-256 and equal complete text, preserving all source/install aliases and digest metadata. Reject invalid UTF-8 before deduplication and decode stdout across chunks correctly. Keep every distinct byte of relevant code under review and retain all blocking judgments.
Validation: catalog validation and 102 tests pass, including full long-line coverage, Unicode boundaries, exact aliases, unequal content/prefix rejection, invalid UTF-8, bounded requests and incomplete-review failures. The real source plus install package fits 48 complete batches (previously 53) with maximum serialized evidence 147,498 characters. Validate the real PR after merge; no safety verdict is bypassed.