fix(mobile): keep a permanent ws error sink in streamSession - #313
Merged
yaojin3616 merged 1 commit intoSep 5, 2026
Merged
Conversation
Closing a still-CONNECTING mux WebSocket from finish() makes ws raise 'error' asynchronously, after cleanup() has removed the real listener. consumeMux guards that self-inflicted error with a permanent empty sink and documents it as a process crash without one; streamSession unwinds with the identical close pattern but had no sink, so aborting a session stream (SSE disconnect, bridge stop) while the gateway handshake is in flight could take the whole Electron main process down. Add the same permanent sink with a lockstep comment, plus an integration test that holds the mux upgrade open and aborts the SSE request: without the sink the run dies on an unhandled 'error' at the close site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a still-CONNECTING mux WebSocket from finish() makes ws raise 'error' asynchronously, after cleanup() has removed the real listener. consumeMux guards that self-inflicted error with a permanent empty sink and documents it as a process crash without one; streamSession unwinds with the identical close pattern but had no sink, so aborting a session stream (SSE disconnect, bridge stop) while the gateway handshake is in flight could take the whole Electron main process down.
Add the same permanent sink with a lockstep comment, plus an integration test that holds the mux upgrade open and aborts the SSE request: without the sink the run dies on an unhandled 'error' at the close site.