fix(update): compare prerelease identifiers numerically, not lexicogr… - #315
Merged
yaojin3616 merged 1 commit intoSep 5, 2026
Merged
Conversation
…aphically
compareVersions ('rc.10' < 'rc.9' under string comparison) mis-ordered
any prerelease that reached a two-digit counter in three places that must
stay in lockstep: the update feed filter, the preload's picker
newer/older + downgrade split (pendingDowngrade skips the downgrade
confirm dialog on a mislabeled upgrade), and the release-script index
generator that feeds dshdesktop.com/updates/versions.json.
Implement semver-style precedence (numeric identifiers compared
numerically and below alphanumeric ones, fewer identifiers sort below
more) in all three copies and pin rc.10 > rc.9 plus identifier rules in
both test suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…aphically
compareVersions ('rc.10' < 'rc.9' under string comparison) mis-ordered any prerelease that reached a two-digit counter in three places that must stay in lockstep: the update feed filter, the preload's picker newer/older + downgrade split (pendingDowngrade skips the downgrade confirm dialog on a mislabeled upgrade), and the release-script index generator that feeds dshdesktop.com/updates/versions.json.
Implement semver-style precedence (numeric identifiers compared numerically and below alphanumeric ones, fewer identifiers sort below more) in all three copies and pin rc.10 > rc.9 plus identifier rules in both test suites.