fix(mobile): make cloudflared cleanup really escalate to SIGKILL - #316
Merged
yaojin3616 merged 1 commit intoSep 5, 2026
Merged
Conversation
The SIGKILL fallback guarded itself with child.killed, which Node sets
as soon as kill('SIGTERM') is *called* — not when the process exits — so
the delayed branch was dead code and a cloudflared that ignores SIGTERM
survived every cleanup, leaking an orphaned tunnel process per attempt
and keeping the dead quick-tunnel URL reachable.
Extract terminateChildProcess (SIGTERM, then SIGKILL only while
exitCode/signalCode are still null) mirroring pinggy-tunnel's correct
guard, and pin the escalation, the no-escalation-after-exit, and the
already-exited cases with unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SIGKILL fallback guarded itself with child.killed, which Node sets as soon as kill('SIGTERM') is called — not when the process exits — so the delayed branch was dead code and a cloudflared that ignores SIGTERM survived every cleanup, leaking an orphaned tunnel process per attempt and keeping the dead quick-tunnel URL reachable.
Extract terminateChildProcess (SIGTERM, then SIGKILL only while exitCode/signalCode are still null) mirroring pinggy-tunnel's correct guard, and pin the escalation, the no-escalation-after-exit, and the already-exited cases with unit tests.